Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix List's missing children metadata in JSON writer #13869

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Fix List's missing children metadata in JSON writer #13869

merged 3 commits into from
Aug 16, 2023

Conversation

karthikeyann
Copy link
Contributor

Description

Fixes #13800
The children metadata of list column was not constructed in Cython code. This is fixed by constructing all children columns metadata for list column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann self-assigned this Aug 12, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 12, 2023
@karthikeyann karthikeyann added bug Something isn't working 3 - Ready for Review Ready for review by team cuIO cuIO issue Cython non-breaking Non-breaking change and removed Python Affects Python cuDF API. labels Aug 12, 2023
@karthikeyann karthikeyann marked this pull request as ready for review August 12, 2023 22:56
@karthikeyann karthikeyann requested a review from a team as a code owner August 12, 2023 22:56
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 16, 2023
bdice
bdice approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fix looks good, and the test coverage appears fine from what I can tell.

@galipremsagar
Copy link
Contributor

/merge

@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change and removed bug Something isn't working non-breaking Non-breaking change labels Aug 16, 2023
@rapids-bot rapids-bot bot merged commit 4fd6dd7 into rapidsai:branch-23.10 Aug 16, 2023
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuIO Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@bdice bdice bdice approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@karthikeyann karthikeyann

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Support List<Struct> key names in the JSON writer
4 participants
@karthikeyann @galipremsagar @bdice @vyasr