Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue with fetching NA from a TimedeltaColumn #13853

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Fix an issue with fetching NA from a TimedeltaColumn #13853

merged 1 commit into from
Aug 11, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #13851

This PR fixes a mistake in _get_np_scalar_from_timedelta64, which has to return cudf.NA instead of None.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Aug 11, 2023
@galipremsagar galipremsagar self-assigned this Aug 11, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner August 11, 2023 15:30
@galipremsagar galipremsagar added bug Something isn't working non-breaking Non-breaking change labels Aug 11, 2023
wence-
wence- approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable!

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 11, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1050325 into rapidsai:branch-23.10 Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- wence- approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] getitem on TimedeltaColumn returns None when there is a null value
3 participants
@galipremsagar @wence- @bdice