Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update make_lists_column_from_scalar to use make_offsets_child_column utility #13841

Merged
merged 5 commits into from
Aug 14, 2023
Merged

Update make_lists_column_from_scalar to use make_offsets_child_column utility #13841

merged 5 commits into from
Aug 14, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Internal lists functions make_lists_column_from_scalar (used by make_column_from_scalar) and generate_list_offsets_and_validities (used by concatenate_list_elements) are updated to use the make_offsets_child_column utility to build the offsets from sizes. This utility handles size_type overflow when computing an offsets column in a consistent way (i.e. throwing std::overflow_error appropriately).

Closes #13833

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added bug Something isn't working 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Aug 9, 2023
@davidwendt davidwendt self-assigned this Aug 9, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 10, 2023
@davidwendt davidwendt marked this pull request as ready for review August 10, 2023 11:53
@davidwendt davidwendt requested a review from a team as a code owner August 10, 2023 11:53
@davidwendt davidwendt changed the title Update make_lists_column_from_scalar to use make_offsets_child_column utility Update make_lists_column_from_scalar to use make_offsets_child_column utility Aug 10, 2023
@davidwendt davidwendt changed the title Update make_lists_column_from_scalar to use make_offsets_child_column utility Update make_lists_column_from_scalar to use make_offsets_child_column utility Aug 14, 2023
@davidwendt davidwendt changed the title Update make_lists_column_from_scalar to use make_offsets_child_column utility Update make_lists_column_from_scalar to use make_offsets_child_column utility Aug 14, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 137ea68 into rapidsai:branch-23.10 Aug 14, 2023
@davidwendt davidwendt deleted the bug-lists-from-scalar branch August 14, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@revans2 revans2 revans2 approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] cudf::make_column_from_scalar on list overflow throws OOM not overflow
4 participants
@davidwendt @revans2 @bdice @ttnghia