Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error for more cases when timezone-aware data is passed to as_column #13835

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Raise error for more cases when timezone-aware data is passed to as_column #13835

merged 2 commits into from
Aug 8, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #13834

This PR raises NotImplementedError for more types of data that are timezone-aware passed to as_column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Aug 8, 2023
@galipremsagar galipremsagar self-assigned this Aug 8, 2023
@galipremsagar galipremsagar marked this pull request as ready for review August 8, 2023 21:23
@galipremsagar galipremsagar requested a review from a team as a code owner August 8, 2023 21:23
@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 8, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 8, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 3190938 into rapidsai:branch-23.10 Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Time-zone-aware DatetimeIndex is being accepted silently by DatetimeIndex constructor
3 participants
@galipremsagar @bdice @mroeschke