Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix any, all reduction behavior for axis=None and warn for other reductions #13831

Merged
merged 15 commits into from
Aug 9, 2023
Merged

Fix any, all reduction behavior for axis=None and warn for other reductions #13831

merged 15 commits into from
Aug 9, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Aug 8, 2023 •
edited
Loading

Description

Fixes: #13827

This PR:

  • Fixes axis=None behavior for any & all reductions.
  • Introduces FutureWarning for upcoming change in behavior for the rest of the reductions since some of the reductions are only updated in pandas-2.0 and the rest would be updated in pandas-3.0.
  • Fixed numpy array function inconsistency because of mismatching default for axis parameter.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the Python Affects Python cuDF API. label Aug 8, 2023
@galipremsagar galipremsagar changed the title Add futurewarning to all reductions Fix any, all reduction behavior for axis=None and warn for other reductions Aug 8, 2023
@galipremsagar galipremsagar self-assigned this Aug 8, 2023
@galipremsagar galipremsagar marked this pull request as ready for review August 8, 2023 19:03
@galipremsagar galipremsagar requested a review from a team as a code owner August 8, 2023 19:03
@galipremsagar galipremsagar requested review from wence- and isVoid August 8, 2023 19:03
@galipremsagar galipremsagar added the bug Something isn't working label Aug 8, 2023
bdice
bdice reviewed Aug 8, 2023
View reviewed changes
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/frame.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_array_function.py Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from bdice August 8, 2023 22:10
bdice
bdice approved these changes Aug 8, 2023
View reviewed changes
python/cudf/cudf/core/dataframe.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Aug 9, 2023
@galipremsagar
Copy link
Contributor Author

/merge

1 similar comment
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit edb25a8 into rapidsai:branch-23.10 Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change bug Something isn't working Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] np.all doesn't perform logical AND over all dimensions when axis=None
2 participants
@galipremsagar @bdice