Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cuFile I/O factories #13829

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix cuFile I/O factories #13829

merged 1 commit into from
Aug 8, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Aug 7, 2023

Description

Factories that instantiate cufile_input_impl/cufile_output_impl objects did not return the created objects, and instead always returned nullptr.
This PR fixes this bug, which made the "GDS" and "OFF" cuFile use policies effectively the same.
The default policy value, "KVIKIO", should be unaffected.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working cuIO cuIO issue non-breaking Non-breaking change labels Aug 7, 2023
@vuule vuule self-assigned this Aug 7, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 7, 2023
@vuule vuule marked this pull request as ready for review August 7, 2023 22:18
@vuule vuule requested a review from a team as a code owner August 7, 2023 22:18
@vuule vuule requested review from harrism and ttnghia August 7, 2023 22:18
ttnghia
ttnghia approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, such a nice catch!

@vuule
Copy link
Contributor Author

vuule commented Aug 7, 2023

Wow, such a nice catch!

We can thank @ayushdg for finding the issue. I just caused it :D

@vuule
Copy link
Contributor Author

vuule commented Aug 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit cd3ddca into rapidsai:branch-23.10 Aug 8, 2023
@vuule vuule deleted the bug-return-gds-impl branch August 8, 2023 17:23
@vuule vuule restored the bug-return-gds-impl branch August 10, 2023 03:13
@vuule vuule deleted the bug-return-gds-impl branch August 10, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vuule vuule

Labels
bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuule @karthikeyann @ttnghia