Return a Series from JIT GroupBy apply, rather than a DataFrame #13820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
bug
bdice
reviewed
Aug 4, 2023
| expect = groupby_jit_data.to_pandas().groupby("key1").apply(func) | ||
| got = groupby_jit_data.groupby("key1").apply(func, engine="jit") | ||
|
|
||
| if special_val is np.nan: |
There was a problem hiding this comment.
This sounds like a test that should be marked as xfail. What do you think?
There was a problem hiding this comment.
Yeah, this is a great question. We ran into this on the original JIT groupby apply PR, it's an outstanding issue.
There aren't any obvious solutions that I can see for this problem but I've raised an issue here to track it. I've also xfailed the test and linked there to he issue.
galipremsagar
approved these changes
Aug 8, 2023
bdice
approved these changes
Aug 8, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13809