Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No need to dlsym EnsureS3Finalized we can call it directly #13819

Merged
merged 3 commits into from
Aug 7, 2023
Merged

No need to dlsym EnsureS3Finalized we can call it directly #13819

merged 3 commits into from
Aug 7, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Previously I didn't realize that the ARROW_S3 define was provided to consumers via arrow/util/config.h. We can remove the dlopen hack and just guard the entire S3 logic.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 4, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner August 4, 2023 16:44
@robertmaynard robertmaynard requested review from vyasr and vuule August 4, 2023 16:44
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 4, 2023
vyasr
vyasr approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small issue, but should be good to go once that is fixed.

cpp/tests/io/arrow_io_source_test.cpp Outdated Show resolved Hide resolved
@robertmaynard robertmaynard force-pushed the bug/remove_arrow12_dlopen branch from 723f149 to 4eb8d5b Compare August 7, 2023 13:28
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7eb4071 into rapidsai:branch-23.10 Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vuule vuule vuule approved these changes

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertmaynard @vyasr @bdice @vuule