Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set native handles to null on close in Java wrapper classes #13818

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Set native handles to null on close in Java wrapper classes #13818

merged 1 commit into from
Aug 4, 2023

Conversation

jlowe
Copy link
Member

@jlowe jlowe commented Aug 4, 2023

Description

This updates a few Java wrapper classes that track native resources to zero the native handles when they are closed to make it easier to track down use-after-close errors.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jlowe jlowe added Java Affects Java cuDF API. Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 4, 2023
@jlowe jlowe self-assigned this Aug 4, 2023
@jlowe jlowe requested a review from a team as a code owner August 4, 2023 14:30
gerashegalov
gerashegalov approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

java/src/main/java/ai/rapids/cudf/ChunkedPack.java Show resolved Hide resolved
@jlowe
Copy link
Member Author

jlowe commented Aug 4, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8370cbe into rapidsai:branch-23.10 Aug 4, 2023
@jlowe jlowe deleted the null-on-close branch August 4, 2023 19:30
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerashegalov gerashegalov gerashegalov approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@jlowe jlowe

Labels
4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jlowe @gerashegalov @ttnghia @vyasr