-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to nvCOMP 3.0.4 #13815
Merged
Merged
Upgrade to nvCOMP 3.0.4 #13815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
feature request
New feature or request
non-breaking
Non-breaking change
5 - DO NOT MERGE
Hold off on merging; see PR for details
labels
Aug 3, 2023
7 tasks
/ok to test |
bdice
reviewed
Nov 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update these files before merging:
fetch_rapids.cmake
-- revert changes to this file once the upstream rapids-cmake PR is merged.- "=2.6.1" Line 230 in 56fe5db
- nvcomp==2.6.1
Also remove "TEST" From the PR title.
vuule
added
cuIO
cuIO issue
and removed
5 - DO NOT MERGE
Hold off on merging; see PR for details
labels
Nov 2, 2023
/ok to test |
bdice
added
breaking
Breaking change
and removed
non-breaking
Non-breaking change
labels
Nov 2, 2023
bdice
approved these changes
Nov 9, 2023
raydouglass
approved these changes
Nov 9, 2023
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this pull request
Nov 9, 2023
Update the nvCOMP version used for compression/decompression to 3.0.4. See also: rapidsai/cudf#13815 rapidsai/rapids-cmake#451 Authors: - Vukasin Milovanovic (https://github.com/vuule) - Bradley Dice (https://github.com/bdice) Approvers: - Bradley Dice (https://github.com/bdice) - Mads R. B. Kristensen (https://github.com/madsbk) - Ray Douglass (https://github.com/raydouglass) URL: #314
/ok to test |
/merge |
^ Triggering a merge for when CI finishes. I expect it to pass based on the build logs I was watching. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the nvCOMP version used for cuIO compression/decompression to 3.0.4.
Checklist