Avoid use of CUDF_EXPECTS in libcudf unit tests outside of helper functions with return values #13812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
tests
davidwendt
reviewed
Aug 3, 2023
davidwendt
reviewed
Aug 3, 2023
davidwendt
requested changes
Aug 3, 2023
…impr-test-assert-not-cudf_expects
davidwendt
approved these changes
Aug 3, 2023
ttnghia
approved these changes
Aug 4, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CUDF_EXPECTSshould be used to report internal errors in libcudf. Google test framework has macros that should be used to report failures. TheASSERT_macros replaceCUDF_EXPECTSas they exit the current function (not by throwing asCUDF_EXPECTS, but the effect is very similar).This PR replaces the erroneous use of CUDF_EXPECTS with ASSERT_XYZ macros in unit tests.
Checklist