Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/update libcudf to handle arrow12 changes #13794

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Bug/update libcudf to handle arrow12 changes #13794

merged 7 commits into from
Aug 2, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Contiuation of #13790 as more changes are needed to support Arrow 12 builds from source ( both static and shared ). This fixes issues when building against Arrow with S3 enabled, and corrects missing acero targets.

NVIDIA/spark-rapids-jni#1306

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard
Enable arrow acero which is now a hard requirement of arrow dataset
af12924
@robertmaynard
Workaround when Arrow has no S3 support.
2007175 
On application shutdown libcudf needs to call `EnsureS3Finalized`
before exit. This is tricky since the arrow might not be compiled
with S3 support enabled.

So use dlopen to check for the symbol existence, and call when
it does exist. Only do this in the S3 tests for now as we figure
out a longer term solution.
@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 1, 2023
@robertmaynard robertmaynard requested review from a team as code owners August 1, 2023 18:22
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Aug 1, 2023
@robertmaynard
Copy link
Contributor Author

apache/arrow#36974 is the upstream issue which covers why we need to use dlopen + dlsym to call the S3 finialize function.

bdice
bdice reviewed Aug 1, 2023
View reviewed changes
cpp/tests/io/arrow_io_source_test.cpp Outdated Show resolved Hide resolved
cpp/cmake/thirdparty/get_arrow.cmake Outdated Show resolved Hide resolved
@gerashegalov
Copy link
Contributor

spark-rapids-jni runs into

[INFO]      [exec] CMake Error in CMakeLists.txt:
[INFO]      [exec]   export called with target "arrow_dataset_static" which requires target
[INFO]      [exec]   "arrow_acero_static" that is not in any export set.

with the current state of the PR as the next issue

davidwendt
davidwendt approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@davidwendt davidwendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving C++ changes.

gerashegalov
gerashegalov approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@gerashegalov gerashegalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, spark-rapids-jni build is working with this PR. Thanks!

@robertmaynard robertmaynard requested a review from bdice August 2, 2023 13:32
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit d526530 into rapidsai:branch-23.10 Aug 2, 2023
@gerashegalov gerashegalov mentioned this pull request Aug 2, 2023
Closed
@robertmaynard robertmaynard deleted the bug/update_libcudf_to_handle_arrow12_changes branch August 7, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

@gerashegalov gerashegalov gerashegalov approved these changes

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robertmaynard @gerashegalov @bdice @davidwendt