Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the libcudf cudf::offset_type type #13788

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Remove the libcudf cudf::offset_type type #13788

merged 4 commits into from
Aug 3, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Jul 31, 2023 •
edited
Loading

Description

Replace all occurrences of cudf::offset_type with cudf::size_type
This helps clear up code where sizes are computed and then converted to offsets in-place.

Also, reference #13733

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 31, 2023
@davidwendt davidwendt self-assigned this Jul 31, 2023
@github-actions github-actions bot added Python Affects Python cuDF API. Java Affects Java cuDF API. labels Jul 31, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Aug 1, 2023
@davidwendt davidwendt changed the title Remove cudf::offset_type Remove the libcudf cudf::offset_type type Aug 1, 2023
@davidwendt davidwendt marked this pull request as ready for review August 1, 2023 14:07
@davidwendt davidwendt requested review from a team as code owners August 1, 2023 14:07
@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Aug 1, 2023
brandon-b-miller
brandon-b-miller approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cython approval

bdice
bdice approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions, feel free to apply here or in a follow-up PR.

cpp/src/lists/combine/concatenate_list_elements.cu Outdated Show resolved Hide resolved
cpp/src/lists/interleave_columns.cu Outdated Show resolved Hide resolved
mythrocks
mythrocks approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. I'm glad we're converging on size_type.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9c559c9 into rapidsai:branch-23.10 Aug 3, 2023
@davidwendt davidwendt deleted the remove-offset-type branch August 3, 2023 12:22
@GregoryKimball GregoryKimball mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@ttnghia ttnghia ttnghia approved these changes

@mythrocks mythrocks mythrocks approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @bdice @mythrocks @ttnghia @brandon-b-miller