Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve names of column object in various APIs #13772

Merged
merged 6 commits into from
Jul 28, 2023
Merged

Preserve names of column object in various APIs #13772

merged 6 commits into from
Jul 28, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR preserves column names in various APIs by retaining self._data._level_names and also calculating when to preserve the column names.
Fixes: #13741, #13740

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Jul 26, 2023
@galipremsagar galipremsagar self-assigned this Jul 26, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner July 26, 2023 21:42
@galipremsagar galipremsagar changed the title Preserve column names in various APIs Preserve names of columns in various APIs Jul 26, 2023
@galipremsagar galipremsagar changed the title Preserve names of columns in various APIs Preserve names of column object in various APIs Jul 26, 2023
@galipremsagar galipremsagar mentioned this pull request Jul 27, 2023
Merged
3 tasks
bdice
bdice approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments but nothing blocking. LGTM!

python/cudf/cudf/core/indexed_frame.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_dataframe.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar requested a review from shwina July 28, 2023 15:05
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jul 28, 2023
wence-
wence- approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, but I think this makes sense.

Although, the index alignment is pretty hairy...

python/cudf/cudf/core/indexed_frame.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/dataframe.py Show resolved Hide resolved
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit f00e922 into rapidsai:branch-23.10 Jul 28, 2023
@galipremsagar galipremsagar mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@bdice bdice bdice approved these changes

@shwina shwina shwina approved these changes

@wence- wence- wence- approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Constructing a DataFrame with a multi-level column does not work
5 participants
@galipremsagar @wence- @shwina @bdice @mroeschke