Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix writing of ORC files with empty child string columns #13745

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Fix writing of ORC files with empty child string columns #13745

merged 3 commits into from
Jul 25, 2023

Conversation

vuule
Copy link
Contributor

@vuule vuule commented Jul 24, 2023 •
edited
Loading

Description

Closes #13742
Fixes an OOB access in rowgroup_char_counts_kernel when the input column has no rows. This can happen with string columns with a parent list column.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vuule vuule added bug Something isn't working cuIO cuIO issue labels Jul 24, 2023
@vuule vuule self-assigned this Jul 24, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 24, 2023
@vuule vuule added non-breaking Non-breaking change and removed libcudf Affects libcudf (C++/CUDA) code. labels Jul 24, 2023
@vuule vuule mentioned this pull request Jul 24, 2023
Closed
@vuule vuule changed the title Bug write orc empty child string column Fix writing of ORC files with empty child string columns Jul 25, 2023
revans2
revans2 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this appears to have fixed the issue. I can read and write the files on the GPU/CPU and get the same answer in both cases.

@revans2 revans2 mentioned this pull request Jul 25, 2023
Merged
@vuule vuule marked this pull request as ready for review July 25, 2023 15:25
@vuule vuule requested a review from a team as a code owner July 25, 2023 15:25
@vuule vuule requested review from vyasr and hyperbolic2346 July 25, 2023 15:25
vyasr
vyasr approved these changes Jul 25, 2023
View reviewed changes
cpp/src/io/orc/dict_enc.cu Outdated Show resolved Hide resolved
@vuule @vyasr
Update cpp/src/io/orc/dict_enc.cu
30671a6 
Co-authored-by: Vyas Ramasubramani <[email protected]>
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jul 25, 2023
@vuule vuule added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 25, 2023
@vuule
Copy link
Contributor Author

vuule commented Jul 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8306ea0 into rapidsai:branch-23.08 Jul 25, 2023
@vuule vuule deleted the bug-write_orc-empty-child-string-column branch July 25, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikeyann karthikeyann karthikeyann approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@revans2 revans2 revans2 approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@vuule vuule

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cuIO cuIO issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Illegal memory access when writing an ORC file
5 participants
@vuule @vyasr @revans2 @hyperbolic2346 @karthikeyann