Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce deprecations and add clarifications around existing deprecations #13710

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Enforce deprecations and add clarifications around existing deprecations #13710

merged 5 commits into from
Jul 17, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Jul 17, 2023 •
edited
Loading

Description

Fixes: #13619
This PR enforces deprecation warnings and adds comments around the existing deprecation warnings that shouldn't be dropped right now.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function breaking Breaking change labels Jul 17, 2023
@galipremsagar galipremsagar requested a review from bdice July 17, 2023 21:13
@galipremsagar galipremsagar self-assigned this Jul 17, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner July 17, 2023 21:13
@galipremsagar galipremsagar requested a review from mroeschke July 17, 2023 21:13
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 17, 2023
bdice
bdice approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions, otherwise LGTM! Thanks so much for picking this up before burndown. 🙇

docs/cudf/source/developer_guide/contributing_guide.md Outdated Show resolved Hide resolved
python/cudf/cudf/io/orc.py Outdated Show resolved Hide resolved
python/cudf/cudf/io/orc.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Jul 17, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 494535e into rapidsai:branch-23.08 Jul 17, 2023
@wence- wence- mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice bdice approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge breaking Breaking change improvement Improvement / enhancement to an existing function Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add code comments to deprecations that depend on upstream pandas changes
3 participants
@galipremsagar @bdice @mroeschke