Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer PTX file load to runtime #13690

Merged
merged 15 commits into from
Jan 17, 2024
Merged

Defer PTX file load to runtime #13690

merged 15 commits into from
Jan 17, 2024

Conversation

brandon-b-miller
Copy link
Contributor

This PR fixes an issue where cuDF fails to import on machines with no NVIDIA GPU present.

cc @shwina

@brandon-b-miller brandon-b-miller requested a review from a team as a code owner July 12, 2023 14:21
@brandon-b-miller brandon-b-miller self-assigned this Jul 12, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label Jul 12, 2023
@brandon-b-miller brandon-b-miller added bug Something isn't working non-breaking Non-breaking change labels Jul 12, 2023
@brandon-b-miller brandon-b-miller changed the base branch from branch-23.08 to branch-24.02 December 15, 2023 20:45
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 15, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@brandon-b-miller
Copy link
Contributor Author

/ok to test

@brandon-b-miller
Copy link
Contributor Author

/ok to test

@brandon-b-miller
Copy link
Contributor Author

/ok to test

@brandon-b-miller
Copy link
Contributor Author

/ok to test

@brandon-b-miller
Copy link
Contributor Author

/ok to test

@brandon-b-miller
Copy link
Contributor Author

/ok to test

vyasr
vyasr reviewed Jan 10, 2024
View reviewed changes
python/cudf/cudf/tests/test_no_cuinit.py Outdated
text=True,
cwd="/",
)
assert output.returncode == 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the test failing because there's a nonzero return code in this case?

@brandon-b-miller
Copy link
Contributor Author

/ok to test

@brandon-b-miller
Copy link
Contributor Author

/ok to test

@bdice bdice mentioned this pull request Jan 17, 2024
Merged
3 tasks
@vyasr
Copy link
Contributor

vyasr commented Jan 17, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Jan 17, 2024

@brandon-b-miller I resolved the conflicts. Hopefully I got the styling right, otherwise a quick pre-commit run might be needed.

vyasr
vyasr approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again to say that the move of the test to a new file looks like the right solution to the failures we were observing earlier.

@vyasr
Copy link
Contributor

vyasr commented Jan 17, 2024

/ok to test

@vyasr
Copy link
Contributor

vyasr commented Jan 17, 2024

/merge

@rapids-bot rapids-bot bot merged commit c811987 into rapidsai:branch-24.02 Jan 17, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice bdice approved these changes

@shwina shwina shwina approved these changes

@galipremsagar galipremsagar Awaiting requested review from galipremsagar galipremsagar is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@brandon-b-miller brandon-b-miller

Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandon-b-miller @vyasr @shwina @bdice