Allow ORC and Parquet writers to write nullable columns without nulls as non-nullable #13675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vuule
added
cuIO
ttnghia
reviewed
Jul 10, 2023
harrism
approved these changes
Jul 11, 2023
| cudf::io::orc_writer_options::builder(cudf::io::sink_info{filepath}, expected) | ||
| .metadata(&expected_metadata); | ||
| // Writer should be able to write a column without nulls as non-nullable | ||
| EXPECT_NO_THROW(cudf::io::write_orc(out_opts)); |
There was a problem hiding this comment.
Just a nit, either way is fine, but I don't think EXPECT_NO_THROW is required. If it throws and the exception is not caught, the test fails anyway.
There was a problem hiding this comment.
I use it just to make it easier to see what we're checking. I prefer to have the macro for this reason.
…fea-write-no-nulls-as-non-nullable
…om/vuule/cudf into fea-write-no-nulls-as-non-nullable
ttnghia
approved these changes
Jul 12, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #7654, #13010
Writers have a strict check for nullability when applying the user metadata's nullability options, because checking the actual number of nulls is (was) not cheap.
Since we now create all columns with a known number of nulls, the
null_countcheck became cheap and we have no reason to prevent columns without nulls to be written as non-nullable.This PR changes the condition to allow this case.
The PR does not address the issue with sliced columns, where it's not possible to write sliced column as non-nullable, even if the slice has no nulls. That check is still not cheap :)
Checklist