Fix loc-getitem ordering when index contains duplicate labels #13659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the index has duplicate labels then it is not sufficient to sort with the ordering induced by gathering the requested keys since the duplicate keys arrive in non-deterministic order from the join in the table that is being looked up from. To fix this, sort additionally by a secondary key that is the ordering induced by gathering from the donor table. - Closes rapidsai#13658
wence-
force-pushed
the
wence/fix/issue-13658
branch
from
e82fb11 to
65bf861
Compare
galipremsagar
requested changes
Jul 11, 2023
Co-authored-by: GALI PREM SAGAR <[email protected]>
galipremsagar
approved these changes
Jul 12, 2023
galipremsagar
added
the
5 - Ready to Merge
|
/merge |
|
Thanks Prem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the index has duplicate labels then it is not sufficient to sort with the ordering induced by gathering the requested keys since the duplicate keys arrive in non-deterministic order from the join in the table that is being looked up from. To fix this, sort additionally by a secondary key that is the ordering induced by gathering from the donor table.
Checklist