Fix has_nonempty_nulls ignoring column offset
#13647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttnghia
added
bug
ttnghia
commented
Jun 29, 2023
Comment on lines
+45
to
+46
| auto const offsets = (type == type_id::STRING) ? (strings_column_view{input}).offsets_begin() | ||
| : (lists_column_view{input}).offsets_begin(); |
There was a problem hiding this comment.
FYI: offsets_begin = offsets().begin<offset_type>() + offset().
davidwendt
approved these changes
Jun 29, 2023
razajafri
approved these changes
Jun 29, 2023
hyperbolic2346
approved these changes
Jun 29, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes
has_nonempty_nullsthat always access the column offsets without considering the starting offset. As such, it may give wrong answer if the input column is sliced.Closes #13638.