Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump typing_extensions minimum version to 4.0.0 #13618

Merged

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jun 26, 2023

Description

Closes #13616

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added Python Affects Python cuDF API. conda labels Jun 26, 2023
@shwina shwina added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 26, 2023
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update

- typing_extensions
too. Then this is good to go.

@shwina shwina marked this pull request as ready for review June 26, 2023 20:44
@shwina shwina requested review from a team as code owners June 26, 2023 20:44
@shwina shwina requested review from vyasr and charlesbluca June 26, 2023 20:44
@shwina
Copy link
Contributor Author

shwina commented Jun 26, 2023

/merge

@vyasr vyasr added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jun 26, 2023
@vyasr
Copy link
Contributor

vyasr commented Jun 26, 2023

I don't know exactly what the process is here. Since we already know we want to hotfix this for 23.06, do we target this at 23.08 then cherry-pick the commit, or do we target at 23.06 and then let the forward-merger take over @raydouglass?

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'm not sure how to move this forward.

@raydouglass
Copy link
Member

raydouglass commented Jun 28, 2023

do we target this at 23.08 then cherry-pick the commit, or do we target at 23.06 and then let the forward-merger take over

You can do either. Merging to branch-23.06 and letting the forward-merger merge into branch-23.08 is probably easier. That said, it looks like this PR branch was branched originally from 23.08 so it needs to be rebased before merging into 23.06. So six of one, half dozen the other in this case.

Edit: Actually, merging to branch-23.06 then forward merging will be cleaner. If you cherry-pick, the forward-merge PR will have conflicts requiring manual intervention.

@shwina shwina changed the base branch from branch-23.08 to branch-23.06 June 28, 2023 18:46
@shwina shwina requested review from a team as code owners June 28, 2023 18:46
@shwina shwina requested review from divyegala and removed request for a team June 28, 2023 18:46
@shwina shwina changed the base branch from branch-23.06 to branch-23.08 June 28, 2023 18:46
@shwina
Copy link
Contributor Author

shwina commented Jun 28, 2023

OK, then I'll open a new PR targeting 23.06

@bdice
Copy link
Contributor

bdice commented Jun 28, 2023

@shwina FYI, I think the cleanest way to do this (without sending tons of GitHub notifications) is to rebase locally, force push, then change the target branch of the PR.

@shwina
Copy link
Contributor Author

shwina commented Jun 28, 2023

Actually with @bdice's help I'm going to finally figure out how to rebase correctly.

@shwina shwina force-pushed the bump-typing-extensions-dependency branch from cf5096c to 5c3ea95 Compare June 28, 2023 19:01
@bdice bdice removed request for a team, divyegala, vyasr and charlesbluca June 28, 2023 19:10
@shwina shwina changed the base branch from branch-23.08 to branch-23.06 June 28, 2023 19:13
@shwina shwina removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Jun 28, 2023
@raydouglass raydouglass merged commit 335fcd1 into rapidsai:branch-23.06 Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] typing_extensions needs a pin for >= 4.0.0 for pip packages
6 participants