-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump typing_extensions minimum version to 4.0.0 #13618
Bump typing_extensions minimum version to 4.0.0 #13618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update
cudf/conda/recipes/cudf/meta.yaml
Line 78 in 12210fd
- typing_extensions |
/merge |
I don't know exactly what the process is here. Since we already know we want to hotfix this for 23.06, do we target this at 23.08 then cherry-pick the commit, or do we target at 23.06 and then let the forward-merger take over @raydouglass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm not sure how to move this forward.
You can do either. Merging to Edit: Actually, merging to |
OK, then I'll open a new PR targeting 23.06 |
@shwina FYI, I think the cleanest way to do this (without sending tons of GitHub notifications) is to rebase locally, force push, then change the target branch of the PR. |
Actually with @bdice's help I'm going to finally figure out how to rebase correctly. |
cf5096c
to
5c3ea95
Compare
Description
Closes #13616
Checklist