Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XXHash_64 hash function to cudf #13612
Add XXHash_64 hash function to cudf #13612
Changes from 45 commits
05868c9
a4dd39b
f39bba0
53603fc
f9436d3
f318e72
de00dc4
660357e
25202b6
a5a0d4b
c9c0624
df5b8db
e4abab3
aaafd8e
ac16d14
e3b6839
9dc57e4
3a5dd7d
3b4dbb8
41c64b4
7d09f76
c55175e
1ce895d
65b6bad
a541a3e
9e2ab2c
6c5176b
cdac656
f4f98e0
fd7bbd4
2e89f98
cd4acbb
5fc46b7
a586b5b
2585657
6ecf2a5
e1e7b8d
9a64914
0624314
cdec016
b8f7b72
3586abe
74cda04
e2b9197
d47d624
606b736
a5e3838
f1f39e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will always emit 4x pipelined
LDG.E.U8
. I wonder if we should add an extra path that performs a singleLDG.E.32
in case the pointer is aligned correctly.Dumb question: When can the start of a string be not aligned to 4 bytes?
Instead of loading and shifting the result, a common pattern is to use a
memcpy
for this:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A string is almost never aligned to 4 bytes. A string is rarely allocated individually but usually part of a larger contiguous block of memory.
The plan is to move these block functions into a separate utilities header where I think we could optimize based on type.
Reference #13706
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Let's leave this as-is for now then.