Use cuco::static_map to build string dictionaries in ORC writer
#13580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fea-write-orc-dict
…fea-write-orc-dict
vuule
added
feature request
…fea-write-orc-dict
…fea-write-orc-dict
…fea-write-orc-dict
…fea-write-orc-dict
…fea-write-orc-dict
PointKernel
approved these changes
Jul 11, 2023
ttnghia
reviewed
Jul 12, 2023
ttnghia
reviewed
Jul 12, 2023
cpp/src/io/orc/dict_enc.cu
Outdated
| } | ||
| namespace cudf::io::orc::gpu { | ||
|
|
||
| constexpr int DEFAULT_BLOCK_SIZE = 256; |
There was a problem hiding this comment.
What block? Data block or thread block? Can you add a comment for it please?
ttnghia
reviewed
Jul 12, 2023
ttnghia
reviewed
Jul 12, 2023
ttnghia
reviewed
Jul 12, 2023
ttnghia
reviewed
Jul 12, 2023
…fea-write-orc-dict
…to fea-write-orc-dict
ttnghia
approved these changes
Jul 13, 2023
vuule
added
5 - Ready to Merge
|
/merge |
This was referenced Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #13326, #10495
This PR reimplements creation of stripe dictionaries in ORC writer to eliminate row group size limitations.
New implementation uses
cuco::static_mapin a way that's very similar to the Parquet writer.PR brings large performance gains because per-column X per-stripe sorting that invoked hundreds of thrust calls is now removed.
Also verified that the original row group size limit (2^16) for dictionary encoding is removed, allowing dictionaries to be applicable to large lists of strings.
Checklist