Add java bindings for distinct count #13573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revans2
added
3 - Ready for Review
ttnghia
reviewed
Jun 14, 2023
Comment on lines
3971
to
3980
| * Count how many rows in the column are distinct from one another. | ||
| * @param nullPolicy if nulls should be included or not. | ||
| */ | ||
| public int distinctCount(NullPolicy nullPolicy) { | ||
| return distinctCount(getNativeView(), nullPolicy.includeNulls, false); | ||
| } | ||
|
|
||
| /** | ||
| * Count how many rows in the column are distinct from one another. | ||
| * Nulls are included. |
There was a problem hiding this comment.
Please also clarify the last parameter in the doc. What does false mean here?
There was a problem hiding this comment.
What parameter? The false in the native code?
ttnghia
reviewed
Jun 14, 2023
| @@ -3999,6 +4015,8 @@ static DeviceMemoryBufferView getOffsetsBuffer(long viewHandle) { | |||
| } | |||
|
|
|||
| // Native Methods | |||
| private static native int distinctCount(long handle, boolean nullsIncluded, boolean nansAreNulls); | |||
There was a problem hiding this comment.
Why do we need this parameter? I don't see any public Java API calling it. If we are not using it then should we just remove it completely from Java code?
There was a problem hiding this comment.
I added it thinking that there was a java enum that corresponded to it, but never got around to adding in the enum. I can remove it if we want to.
ttnghia
reviewed
Jun 14, 2023
Comment on lines
4753
to
4754
|
|
||
|
|
There was a problem hiding this comment.
Nit: Too many empty lines.
ttnghia
approved these changes
Jun 14, 2023
|
/merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds in java bindings for cudf::distinct_count for both table and column APIs.
Checklist