Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JNI for lists::concatenate_list_elements #13547

Merged
merged 18 commits into from
Jun 14, 2023
Merged

Add JNI for lists::concatenate_list_elements #13547

merged 18 commits into from
Jun 14, 2023

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Jun 9, 2023 •
edited
Loading

This implements JNI work for lists::concatenate_list_elements to expose the API to Java usage.

@ttnghia ttnghia added feature request New feature or request 3 - Ready for Review Ready for review by team Spark Functionality that helps Spark RAPIDS non-breaking Non-breaking change labels Jun 9, 2023
@ttnghia ttnghia self-assigned this Jun 9, 2023
@github-actions github-actions bot added Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jun 9, 2023
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Jun 10, 2023
@ttnghia ttnghia force-pushed the jni_concatenate_list_elements branch from 10dfc9f to 677c7bd Compare June 10, 2023 22:11
@ttnghia ttnghia marked this pull request as ready for review June 11, 2023 03:10
@ttnghia ttnghia requested a review from a team as a code owner June 11, 2023 03:10
@ttnghia ttnghia mentioned this pull request Jun 11, 2023
Closed
@ttnghia ttnghia marked this pull request as draft June 12, 2023 18:36
@ttnghia ttnghia marked this pull request as ready for review June 12, 2023 21:12
@ttnghia ttnghia mentioned this pull request Jun 12, 2023
Merged
revans2
revans2 approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just have a nit with the docs, but beyond that it is fine.

java/src/main/java/ai/rapids/cudf/ColumnView.java Show resolved Hide resolved
@ttnghia ttnghia force-pushed the jni_concatenate_list_elements branch from 979971d to a40e667 Compare June 14, 2023 13:43
@ttnghia
Copy link
Contributor Author

ttnghia commented Jun 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit 67efaf6 into rapidsai:branch-23.08 Jun 14, 2023
@ttnghia ttnghia deleted the jni_concatenate_list_elements branch June 15, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgravescs tgravescs tgravescs left review comments

@revans2 revans2 revans2 approved these changes

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team feature request New feature or request Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ttnghia @revans2 @tgravescs