-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub infra updates #13542
Closed
Closed
GitHub infra updates #13542
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
4be9ac0
Update issue templates, project and labeling GHAs
jarmak-nv 6f41970
Merge branch 'rapidsai:branch-23.08' into github-infra-updates
jarmak-nv 61f180d
Style updates
jarmak-nv 41eff4f
Merge branch 'branch-23.08' into github-infra-updates
jarmak-nv 45cfa26
Style part 2
jarmak-nv 81d1089
Apply suggestions from code review
jarmak-nv 6693155
Template Updates Per Feedback
jarmak-nv 1bfe844
Delete trailing whitespace
jarmak-nv 36f9fcf
Merge branch 'rapidsai:branch-23.08' into github-infra-updates
jarmak-nv 2620894
Apply suggestions from code review
jarmak-nv 14df3c1
Revert doc and feature request templates
jarmak-nv 9a408bf
Merge branch 'rapidsai:branch-23.08' into github-infra-updates
jarmak-nv 0592074
Style fixes
jarmak-nv 2c3c29c
Add collapsable sections to logs and env details
jarmak-nv 1e7d4c5
Merge branch 'branch-23.08' into github-infra-updates
jarmak-nv 6474626
Style fix
jarmak-nv 7acd2f6
Move 'if docker...' section to description
jarmak-nv 727954a
[skip ci] revert bug template, comment from bot
jarmak-nv 444222c
Merge branch 'branch-23.10' into github-infra-updates
jarmak-nv ab7cf69
Merge branch 'branch-23.10' into github-infra-updates
jarmak-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# SPDX-FileCopyrightText: Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
name: Triage outside issues | ||
|
||
on: | ||
issues: | ||
types: | ||
- opened | ||
|
||
env: | ||
GITHUB_TOKEN: ${{ github.token }} | ||
|
||
permissions: | ||
issues: write | ||
|
||
jobs: | ||
Label-Issue: | ||
runs-on: ubuntu-latest | ||
# Only run if the issue author is not part of RAPIDS | ||
if: ${{ ! contains(fromJSON('["OWNER", "MEMBER", "CONTRIBUTOR", "COLLABORATOR"]'), github.event.issue.author_association)}} | ||
steps: | ||
- name: add-external-labels | ||
run: | | ||
issue_url=${{ github.event.issue.html_url }} | ||
gh issue edit ${issue_url} --add-label "External" | ||
|
||
- name: add-comment-to-issue | ||
run: | | ||
issue_url=${{ github.event.issue.html_url }} | ||
author=${{ github.event.issue.user.login }} | ||
echo ${author} | ||
gh issue comment ${issue_url} --body "Hi @${author}! | ||
|
||
Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can! | ||
In the meantime, feel free to add any relevant information to this issue." |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I am not in favor of autoresponders if their text is so simple. It adds noise to the conversation that I don't think is helpful. If it were "smart" and pointed to a contributing guide for the relevant component (libcudf/cudf Python) or linked to potentially related issues, then perhaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree in that auto-responders are not my favorite. Unfortunately for the Slack integrations to notify us it requires a triggering event, and that's only either Issue creation, or comment. Since the GHA to label happens after issue creation, we need to make the comment to have it fire.
I think we could have the GHA delete the comment immediately after posting, but that might fire some confusing emails to filers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Slack integration are you talking about? I already get GitHub notifications via Slack for every new issue that is filed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of a new process to track/triage
External
issues easier. https://github.com/integrations/slack#creating-a-filter when issues withExternal
exist they can go into specific channels to ensure timely response/handling.The goal is to reduce noise of all issues/comments and only focus on a small subset.