Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate strings_to_categorical in cudf.read_parquet #13540

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Deprecate strings_to_categorical in cudf.read_parquet #13540

merged 2 commits into from
Jun 9, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

This PR deprecates string_to_categorical because of the ambiguous naming to the end users and no real use for this parameter at this point. Pandas or pyarrow don't have this parameter, it was exclusive to cudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 9, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner June 9, 2023 14:22
@galipremsagar galipremsagar self-assigned this Jun 9, 2023
@galipremsagar galipremsagar requested review from bdice and mroeschke June 9, 2023 14:22
@galipremsagar galipremsagar changed the base branch from branch-23.08 to branch-23.06 June 9, 2023 18:59
@galipremsagar galipremsagar requested review from a team as code owners June 9, 2023 18:59
@galipremsagar galipremsagar requested review from robertmaynard and removed request for a team June 9, 2023 18:59
@galipremsagar galipremsagar changed the base branch from branch-23.06 to branch-23.08 June 9, 2023 18:59
@galipremsagar galipremsagar removed request for a team and robertmaynard June 9, 2023 18:59
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 4 - Needs cuIO Reviewer labels Jun 9, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c270986 into rapidsai:branch-23.08 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galipremsagar @ttnghia @mroeschke