Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to scikit-build-core #13531

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Switch to scikit-build-core #13531

merged 4 commits into from
Dec 14, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 7, 2023 •
edited
Loading

Description

Contributes to rapidsai/build-planning#2

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added CMake CMake build issue conda Python Affects Python cuDF API. labels Jun 7, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch from 57b1a3a to 318f262 Compare June 7, 2023 23:21
@vyasr vyasr self-assigned this Jun 7, 2023
@vyasr vyasr added improvement Improvement / enhancement to an existing function breaking Breaking change non-breaking Non-breaking change and removed non-breaking Non-breaking change labels Jun 7, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch from 9455fd7 to 80545c2 Compare June 8, 2023 21:39
@vyasr vyasr mentioned this pull request Jun 9, 2023
Merged
5 tasks
@vyasr vyasr force-pushed the feat/scikit_build_core branch from 0f2f075 to e10d3dc Compare June 14, 2023 15:21
@vyasr vyasr force-pushed the feat/scikit_build_core branch from 0529430 to 550223f Compare December 1, 2023 23:34
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 1, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@vyasr vyasr changed the base branch from branch-23.08 to branch-24.02 December 1, 2023 23:35
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. ci and removed Python Affects Python cuDF API. labels Dec 1, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch from 550223f to 727d17e Compare December 1, 2023 23:37
@github-actions github-actions bot added Python Affects Python cuDF API. and removed libcudf Affects libcudf (C++/CUDA) code. ci labels Dec 1, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch 2 times, most recently from 100486c to ea9b7d9 Compare December 1, 2023 23:56
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 2, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch 2 times, most recently from 8c4dc8e to be8be0c Compare December 2, 2023 02:25
@github-actions github-actions bot removed the libcudf Affects libcudf (C++/CUDA) code. label Dec 2, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch from be8be0c to 044d294 Compare December 5, 2023 00:44
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. ci and removed libcudf Affects libcudf (C++/CUDA) code. labels Dec 5, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch from d26799e to 2d7396b Compare December 5, 2023 23:41
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Dec 5, 2023
@vyasr vyasr force-pushed the feat/scikit_build_core branch 2 times, most recently from 3b24626 to c8f9b90 Compare December 12, 2023 22:13
@vyasr vyasr force-pushed the feat/scikit_build_core branch from c8f9b90 to 8f0645d Compare December 12, 2023 22:17
@vyasr vyasr marked this pull request as ready for review December 12, 2023 23:20
@vyasr vyasr requested review from a team as code owners December 12, 2023 23:20
@vyasr vyasr changed the title Switch from scikit-build to scikit-build-core Switch to scikit-build-core Dec 12, 2023
@jarmak-nv jarmak-nv mentioned this pull request Dec 13, 2023
Closed
bdice
bdice approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one question.

dependencies.yaml Show resolved Hide resolved
rjzamora
rjzamora approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@rjzamora rjzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dask-cudf changes seem fine to me. Thanks!

@vyasr
Copy link
Contributor Author

vyasr commented Dec 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit cee6429 into rapidsai:branch-24.02 Dec 14, 2023
67 checks passed
@vyasr vyasr deleted the feat/scikit_build_core branch December 14, 2023 00:42
@vyasr vyasr mentioned this pull request Jan 11, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Jan 12, 2024
@vyasr
Fix CMake args (#14746)
3c55a6e 
This was an oversight in #13531

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Bradley Dice (https://github.com/bdice)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #14746
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@rjzamora rjzamora rjzamora approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@wence- wence- Awaiting requested review from wence- wence- is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@vyasr vyasr

Labels
breaking Breaking change CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vyasr @bdice @ajschmidt8 @rjzamora