Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove preload lib from CMake for now #13519

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Remove preload lib from CMake for now #13519

merged 1 commit into from
Jun 7, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 6, 2023 •
edited
Loading

Description

The preload lib is already being specified in the CI testing environment via bash, so this change has no short-term effect. The long-term solution is being worked on in #13513.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Jun 6, 2023
@vyasr vyasr self-assigned this Jun 6, 2023
@vyasr vyasr added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Jun 6, 2023
@vyasr vyasr marked this pull request as ready for review June 6, 2023 22:34
@vyasr vyasr requested a review from a team as a code owner June 6, 2023 22:34
@vyasr vyasr requested review from bdice and vuule June 6, 2023 22:34
@vyasr
Copy link
Contributor Author

vyasr commented Jun 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit bb92f16 into rapidsai:branch-23.08 Jun 7, 2023
@vyasr vyasr deleted the chore/remove_preload branch June 7, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

@vuule vuule Awaiting requested review from vuule vuule is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @bdice @davidwendt