Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused max_rows_tensor parameter from subword tokenizer #13463

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Remove unused max_rows_tensor parameter from subword tokenizer #13463

merged 4 commits into from
Jun 1, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Removes the max_rows_tensor parameter is from the nvtext::subword_tokenize API since it is no longer required. The parameter was intended to size the temporary working memory for the internal functions. Since some general rework it was no longer used but never removed from the API.
Also updates the Python/Cython calls which had been hard-coding a default value anyway.

Reference issue #13458 found this issue.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function breaking Breaking change labels May 26, 2023
@davidwendt davidwendt self-assigned this May 26, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 26, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 30, 2023
@davidwendt davidwendt marked this pull request as ready for review May 30, 2023 20:37
@davidwendt davidwendt requested review from a team as code owners May 30, 2023 20:37
bdice
bdice approved these changes May 30, 2023
View reviewed changes
python/cudf/cudf/_lib/nvtext/subword_tokenize.pyx Outdated Show resolved Hide resolved
python/cudf/cudf/_lib/nvtext/subword_tokenize.pyx Outdated Show resolved Hide resolved
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ebb5875 into rapidsai:branch-23.08 Jun 1, 2023
@davidwendt davidwendt deleted the subword-remove-max-tensor branch June 1, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@mroeschke mroeschke mroeschke approved these changes

@bdice bdice bdice approved these changes

@vyasr vyasr vyasr approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Python Affects Python cuDF API. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidwendt @vyasr @bdice @mroeschke @divyegala