-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cudf::repeat logic when count is zero #13459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would support this fix going into 23.06. It's very low risk and fixes a crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this fixes the crashes we saw in our Spark integration test. Thanks for the quick turnaround, @davidwendt!
Note that we would like to see this in 23.06 to unblock our release pipelines there.
Oops, I made a mistake (and fixed it). I changed the target branch to 23.06 and reverted it. We do need to rebase this over |
My git foo is weak so I'll need help rebasing this PR. |
b5fe09f
to
4ff56da
Compare
@davidwendt the rebase looks good to me. I think we’ll need an admin merge once CI passes. |
Description
Fixes logic in
cudf::repeat
to check forcount==0
before using it to check for possible out-of-bounds output size result.Added a specific gtest for this as well.
Closes #13458
Checklist