-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsanitized output of scan with strings #13455
Fix unsanitized output of scan with strings #13455
Conversation
Thank you @davidwendt!! That was fast! |
@razajafri Do you want to test this fixes your test from #13449 before I merge it? |
Ideally, I would like to do that but I won't be able to get to it until EOD today. |
I did a quick run and it is looking good. I would like to run all of our tests, but the ones that were failing before are passing with this change now. |
/merge |
@davidwendt Thank you for the quick resolution. I just tested this with the plugin and it works |
Description
Fixes output from
cudf::scan
to return sanitized null entries. The null rows are expected to contain no characters if the input null rows are also empty.The code logic is changed to compute the output validity mask first and use the mask to help build the gather map used for creating the output strings column. This rework also cleans up an unused parameter from internal functions
detail::scan_inclusive
anddetail::scan_exclusive
.An additional check is added to the
scan_test
utility to verify the results contain empty null entries.Closes #13449
Checklist