Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward-merge branch-23.06 to branch-23.08 #13451

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

GPUtester
Copy link
Collaborator

Forward-merge triggered by push to branch-23.06 that creates a PR to keep branch-23.08 up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge.

These must be treated specially and not accidentally converted to integers before indexing.

- Closes #13015
- Closes #13265
- Closes #13270

Introduces tighter guards for loc-based indexing with Series where in some circumstances one must align the indices of the indexed object and the indexer. These now raise NotImplementedError rather than returning incorrect answers.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)
  - Ashwin Srinath (https://github.com/shwina)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)

URL: #13402
@GPUtester GPUtester requested a review from a team as a code owner May 25, 2023 17:58
@GPUtester GPUtester requested review from vyasr and charlesbluca May 25, 2023 17:58
@GPUtester GPUtester merged commit 37f76c8 into branch-23.08 May 25, 2023
@GPUtester
Copy link
Collaborator Author

SUCCESS - forward-merge complete.

@github-actions github-actions bot added the Python Affects Python cuDF API. label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants