-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batch processing for parquet writer #13438
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1641a93
Add test
ttnghia 3182fbf
Fix a bug
ttnghia ba9c766
Modify test
ttnghia 52d1cb1
Fix batch processing
ttnghia 641a4fb
Reverse test
ttnghia 65cc5d6
Reverse changes from upstream
ttnghia a9dbba3
Revert "Fix batch processing"
ttnghia c150c10
Lift the limit for batch size
ttnghia 5b4f9f5
Merge branch 'branch-23.06' into fix_parquet_writer
ttnghia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1779,10 +1779,15 @@ auto convert_table_to_parquet_data(table_input_metadata& table_meta, | |
std::fill_n(std::back_inserter(rg_to_part), num_rg_in_part[p], p); | ||
} | ||
|
||
// Batch processing is no longer supported. | ||
// This line disables batch processing (so batch size will no longer be limited at 1GB as before). | ||
// TODO: All the relevant code will be removed in the follow-up work: | ||
// https://github.com/rapidsai/cudf/issues/13440 | ||
auto const max_bytes_in_batch = std::numeric_limits<size_t>::max(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. OK, so this is the minimal change to "switch off" batching without changing any of the logic, which is likely the safest thing to do. |
||
|
||
// Initialize batches of rowgroups to encode (mainly to limit peak memory usage) | ||
std::vector<size_type> batch_list; | ||
size_type num_pages = 0; | ||
size_t max_bytes_in_batch = 1024 * 1024 * 1024; // 1GB - TODO: Tune this | ||
size_t max_uncomp_bfr_size = 0; | ||
size_t max_comp_bfr_size = 0; | ||
size_t max_chunk_bfr_size = 0; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this needs to be said, but please don't remove this code without further discussion. It could play a role in future performance improvements.