Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid use of std::exclusive_scan in Parquet writer #13434

Merged
merged 6 commits into from
May 25, 2023
Merged

Fix invalid use of std::exclusive_scan in Parquet writer #13434

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a5164da
fix invalid use of std::exclusive_scan
etseidl May 24, 2023
d8b4092
Update cpp/src/io/parquet/writer_impl.cu
etseidl May 24, 2023
b4a3161
review suggestion
etseidl May 24, 2023
f6277f0
clean up total_frags calculation
etseidl May 24, 2023
0a3658a
Merge branch 'branch-23.06' into fix_off_by_one
etseidl May 24, 2023
a6673a1
Merge branch 'rapidsai:branch-23.06' into fix_off_by_one
etseidl May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions cpp/src/io/parquet/writer_impl.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,14 +1706,12 @@ auto convert_table_to_parquet_data(table_input_metadata& table_meta,
// fragments with a (potentially) varying number of fragments per column.

// first figure out the total number of fragments and calculate the start offset for each column
std::vector<size_type> frag_offsets;
std::vector<size_type> frag_offsets(num_columns, 0);
vuule marked this conversation as resolved.
Show resolved Hide resolved
size_type const total_frags = [&]() {
if (frags_per_column.size() > 0) {
std::exclusive_scan(frags_per_column.data(),
frags_per_column.data() + num_columns + 1,
std::back_inserter(frag_offsets),
0);
return frag_offsets[num_columns];
std::exclusive_scan(
frags_per_column.begin(), frags_per_column.end(), frag_offsets.begin(), 0);
return frag_offsets.back() + frags_per_column.back();
} else {
return 0;
}
Expand Down