Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenize with non-space delimiter #13403

Merged
merged 2 commits into from
May 23, 2023
Merged

Fix tokenize with non-space delimiter #13403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e9fa4
Fix tokenize with non-space delimiter
shwina May 22, 2023
811a054
Merge branch 'branch-23.06' into fix-tokenize-non-space-delimiter
shwina May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/cudf/cudf/core/column/string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4609,7 +4609,7 @@ def tokenize(self, delimiter: str = " ") -> SeriesOrIndex:
)
if isinstance(self._parent, cudf.Series):
result.index = self._parent.index.repeat( # type: ignore
self.token_count()
self.token_count(delimiter=delimiter)
)
return result

Expand Down Expand Up @@ -5296,6 +5296,9 @@ def minhash(


def _massage_string_arg(value, name, allow_col=False):
if isinstance(value, cudf.Scalar):
return value

if isinstance(value, str):
return cudf.Scalar(value, dtype="str")

Expand Down
29 changes: 29 additions & 0 deletions python/cudf/cudf/tests/test_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,35 @@ def test_tokenize():
assert_eq(expected, actual)


def test_tokenize_delimiter():
strings = cudf.Series(
[
"the quick fox jumped over the lazy dog",
"the siamésé cat jumped under the sofa",
None,
"",
]
)

expected_values = cudf.Series(
[
"the quick f",
"x jumped ",
"ver the lazy d",
"g",
"the siamésé cat jumped under the s",
"fa",
]
)
expected_index = strings.index.repeat(strings.str.token_count("o"))
expected = cudf.Series(expected_values, index=expected_index)

actual = strings.str.tokenize(delimiter="o")

assert type(expected) == type(actual)
assert_eq(expected, actual)


def test_detokenize():
strings = cudf.Series(
[
Expand Down