Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to closed="right" in IntervalIndex constructor #13394

Merged
merged 2 commits into from
May 22, 2023
Merged

Default to closed="right" in IntervalIndex constructor #13394

merged 2 commits into from
May 22, 2023

Conversation

shwina
Copy link
Contributor

@shwina shwina commented May 19, 2023

Closes #13393

@github-actions github-actions bot added the Python Affects Python cuDF API. label May 19, 2023
@shwina shwina added non-breaking Non-breaking change bug Something isn't working labels May 19, 2023
@shwina shwina changed the title Default to interval="closed" in IntervalIndex constructor Default to closed="right" in IntervalIndex constructor May 21, 2023
@shwina shwina marked this pull request as ready for review May 22, 2023 14:56
@shwina shwina requested a review from a team as a code owner May 22, 2023 14:56
brandon-b-miller
brandon-b-miller approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@brandon-b-miller brandon-b-miller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this breaking for any workflows that passed the default None previously?

@shwina
Copy link
Contributor Author

shwina commented May 22, 2023

No it is not. The default argument is still None, but we make sure to translate that None to 'right' internally

@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 383c3cf into rapidsai:branch-23.06 May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandon-b-miller brandon-b-miller brandon-b-miller approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] IntervalIndex constructor does not default closed= to "right"
3 participants
@shwina @galipremsagar @brandon-b-miller