Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unused argument errors in nvcc 11.5 #13387

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix unused argument errors in nvcc 11.5 #13387

merged 1 commit into from
May 19, 2023

Conversation

abellina
Copy link
Contributor

@abellina abellina commented May 18, 2023 •
edited
Loading

Description

This PR introduced some unused arguments that are causing compilation errors in nvcc 11.5 #13180. Taking care of that here.

@davidwendt found these in his local nvcc 11.5 build

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@abellina abellina added bug Something isn't working non-breaking Non-breaking change labels May 18, 2023
@abellina abellina requested a review from a team as a code owner May 18, 2023 23:52
@abellina abellina requested review from hyperbolic2346 and bdice May 18, 2023 23:52
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label May 18, 2023
@abellina abellina requested a review from davidwendt May 18, 2023 23:53
@abellina abellina changed the title [BUG] Fix unused argument errors in nvcc 11.5 Fix unused argument errors in nvcc 11.5 May 19, 2023
@davidwendt davidwendt added the 3 - Ready for Review Ready for review by team label May 19, 2023
@abellina
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 72c0677 into rapidsai:branch-23.06 May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@ttnghia ttnghia ttnghia approved these changes

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@abellina abellina

Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abellina @bdice @ttnghia @davidwendt