Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates needed to work with jitify that leverages libcudacxx #13383

Merged
merged 3 commits into from
May 24, 2023
Merged

Updates needed to work with jitify that leverages libcudacxx #13383

merged 3 commits into from
May 24, 2023

Conversation

robertmaynard
Copy link
Contributor

@robertmaynard robertmaynard commented May 18, 2023 •
edited by bdice
Loading

Description

This update libcudf with a version of jitify that leverages libcudacxx. This removes compiler issues when the pre-built defines in jitify and libcudacxx diverege due to updates in either package.

At the same time testing locally with CUDA 11.5, 11.8, 12.0, and 12.1 uncovered a couple of compile errors.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 18, 2023
@robertmaynard robertmaynard requested review from a team as code owners May 18, 2023 17:25
@robertmaynard robertmaynard requested review from vyasr and vuule May 18, 2023 17:25
@github-actions github-actions bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels May 18, 2023
@robertmaynard
Copy link
Contributor Author

Requires rapidsai/jitify#16 to be merged.

@robertmaynard robertmaynard force-pushed the bug/latest_libcudacxx_with_jitify_support branch from db5c9a0 to 92a33f5 Compare May 18, 2023 17:36
vuule
vuule reviewed May 19, 2023
View reviewed changes
Copy link
Contributor

@vuule vuule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the copyright year change.

cpp/cmake/Modules/JitifyPreprocessKernels.cmake Outdated Show resolved Hide resolved
cpp/include/cudf/reduction/detail/reduction_operators.cuh Show resolved Hide resolved
@vuule vuule added the 5 - DO NOT MERGE Hold off on merging; see PR for details label May 19, 2023
@robertmaynard robertmaynard force-pushed the bug/latest_libcudacxx_with_jitify_support branch from 156c35f to 5067e02 Compare May 23, 2023 14:10
@robertmaynard robertmaynard removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label May 23, 2023
@robertmaynard robertmaynard requested review from ttnghia and vuule May 23, 2023 14:58
@robertmaynard robertmaynard removed the request for review from a team May 24, 2023 12:53
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 707a480 into rapidsai:branch-23.06 May 24, 2023
@robertmaynard robertmaynard deleted the bug/latest_libcudacxx_with_jitify_support branch May 24, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuule vuule vuule approved these changes

@ttnghia ttnghia ttnghia approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@robertmaynard robertmaynard

Labels
3 - Ready for Review Ready for review by team bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @ttnghia @vuule