Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate cudf::strings::slice_strings APIs that accept delimiters #13373

Merged

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented May 17, 2023

Description

Deprecating cudf::strings::slice_strings functions:
https://docs.rapids.ai/api/libcudf/stable/group__strings__slice.html#gaf1504116d31b0ec4f119f1477bb87ee1

std::unique_ptr<column> slice_strings(
  strings_column_view const& strings,
  string_scalar const& delimiter,
  size_type count,
  rmm::mr::device_memory_resource* mr);

and
https://docs.rapids.ai/api/libcudf/stable/group__strings__slice.html#ga21f01493d15c18d67b66a94f20a24389

std::unique_ptr<column> slice_strings(
  strings_column_view const& strings,
  strings_column_view const& delimiter_strings,
  size_type count,
  rmm::mr::device_memory_resource* mr);

These are not being used by cuDF (Cython) or Spark (JNI) and are quite convoluted and difficult to maintain.
Marking these as deprecated in 23.06 to be removed in 23.08 if possible.
Due to the warning/error compile settings, the benchmarks and the gtests are removed for these functions.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function breaking Breaking change labels May 17, 2023
@davidwendt davidwendt requested a review from a team as a code owner May 17, 2023 19:57
@davidwendt davidwendt self-assigned this May 17, 2023
@davidwendt davidwendt requested review from harrism and PointKernel May 17, 2023 19:57
@davidwendt davidwendt changed the title Deprecate cudf::strings::slice_strings that accept delimiters Deprecate cudf::strings::slice_strings APIs that accept delimiters May 17, 2023
@davidwendt davidwendt added non-breaking Non-breaking change and removed breaking Breaking change labels May 17, 2023
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 132540e into rapidsai:branch-23.06 May 24, 2023
@davidwendt davidwendt deleted the deprecate-slice-with-delimiter branch May 24, 2023 15:34
@revans2
Copy link
Contributor

revans2 commented Jun 14, 2024

@davidwendt we would like to use these in Spark. Would it be possible to un-deprecate them?

@davidwendt
Copy link
Contributor Author

I think you could use cudf::strings::find()/rfind() to get the position values of the delimiter and then pass those positions appropriately to the current cudf::strings::slice_strings() to achieve the same result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants