-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate cudf::strings::slice_strings APIs that accept delimiters #13373
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-23.06
from
davidwendt:deprecate-slice-with-delimiter
May 24, 2023
Merged
Deprecate cudf::strings::slice_strings APIs that accept delimiters #13373
rapids-bot
merged 6 commits into
rapidsai:branch-23.06
from
davidwendt:deprecate-slice-with-delimiter
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
added
3 - Ready for Review
Ready for review by team
libcudf
Affects libcudf (C++/CUDA) code.
strings
strings issues (C++ and Python)
improvement
Improvement / enhancement to an existing function
breaking
Breaking change
labels
May 17, 2023
davidwendt
changed the title
Deprecate cudf::strings::slice_strings that accept delimiters
Deprecate cudf::strings::slice_strings APIs that accept delimiters
May 17, 2023
davidwendt
added
non-breaking
Non-breaking change
and removed
breaking
Breaking change
labels
May 17, 2023
PointKernel
approved these changes
May 17, 2023
ttnghia
approved these changes
May 19, 2023
/merge |
@davidwendt we would like to use these in Spark. Would it be possible to un-deprecate them? |
I think you could use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
improvement
Improvement / enhancement to an existing function
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
strings
strings issues (C++ and Python)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecating
cudf::strings::slice_strings
functions:https://docs.rapids.ai/api/libcudf/stable/group__strings__slice.html#gaf1504116d31b0ec4f119f1477bb87ee1
and
https://docs.rapids.ai/api/libcudf/stable/group__strings__slice.html#ga21f01493d15c18d67b66a94f20a24389
These are not being used by cuDF (Cython) or Spark (JNI) and are quite convoluted and difficult to maintain.
Marking these as
deprecated
in 23.06 to be removed in 23.08 if possible.Due to the warning/error compile settings, the benchmarks and the gtests are removed for these functions.
Checklist