Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate StringIndex and use Index instead #13361

Merged
merged 6 commits into from
May 17, 2023
Merged

Deprecate StringIndex and use Index instead #13361

merged 6 commits into from
May 17, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Pandas doesn't have a StringIndex class, this PR deprecates constructing a string Index with StringIndex constructor and will be removed in next/future release. Instead use Index constructor.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 16, 2023
@galipremsagar galipremsagar requested a review from shwina May 16, 2023 18:02
@galipremsagar galipremsagar requested a review from a team as a code owner May 16, 2023 18:02
@galipremsagar galipremsagar self-assigned this May 16, 2023
@galipremsagar galipremsagar requested a review from isVoid May 16, 2023 18:02
@galipremsagar galipremsagar mentioned this pull request May 16, 2023
Closed
@galipremsagar galipremsagar added the 3 - Ready for Review Ready for review by team label May 16, 2023
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels May 17, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@galipremsagar galipremsagar added bug Something isn't working improvement Improvement / enhancement to an existing function and removed improvement Improvement / enhancement to an existing function bug Something isn't working labels May 17, 2023
@rapids-bot rapids-bot bot merged commit dbf140e into rapidsai:branch-23.06 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwina shwina shwina approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galipremsagar @shwina