Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests of currently unsupported indexing #13338

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Add tests of currently unsupported indexing #13338

merged 3 commits into from
Jun 8, 2023

Conversation

wence-
Copy link
Contributor

@wence- wence- commented May 11, 2023 •
edited
Loading

Description

Add xfailing tests for many indexing corner cases

This gives us observability over changes as we fix things.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 11, 2023
@wence- wence- requested a review from a team as a code owner May 11, 2023 16:08
@wence- wence- requested review from vyasr and isVoid May 11, 2023 16:08
@wence-
Copy link
Contributor Author

wence- commented May 18, 2023

Probably punt this to 23.08

@wence- wence- marked this pull request as draft May 24, 2023 13:25
@wence-
Copy link
Contributor Author

wence- commented May 24, 2023

Will retarget to 23.08.

@wence- wence- force-pushed the wence/fea/document-indexing-bugs branch from 6efa22d to 0ee5477 Compare June 5, 2023 15:33
@github-actions github-actions bot added ci CMake CMake build issue Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jun 5, 2023
@wence- wence- changed the base branch from branch-23.06 to branch-23.08 June 5, 2023 15:37
@wence- wence- marked this pull request as ready for review June 5, 2023 15:38
@wence-
Copy link
Contributor Author

wence- commented Jun 5, 2023 •
edited
Loading

In the interests of making reviewing easier, I'm splitting the indexing rework into more pieces. This one just adds tests for the things we know don't work correctly at present.

@wence- wence- changed the title Refactor iloc.__getitem__ to handle more corner-cases Add tests of currently unsupported indexing Jun 5, 2023
@wence- wence- force-pushed the wence/fea/document-indexing-bugs branch from 0ee5477 to 46f17f7 Compare June 6, 2023 16:19
@github-actions github-actions bot removed ci CMake CMake build issue Java Affects Java cuDF API. libcudf Affects libcudf (C++/CUDA) code. labels Jun 6, 2023
wence- added 2 commits June 7, 2023 17:30
@wence-
Add xfailing tests for many indexing corner cases
d1e7299 
This gives us observability over changes as we fix things.
@wence-
Multiindex iloc failures
5a370f4
@wence- wence- changed the base branch from branch-23.08 to branch-23.06 June 7, 2023 16:33
@wence- wence- requested review from a team as code owners June 7, 2023 16:33
@wence- wence- requested review from nvdbaranec and removed request for a team June 7, 2023 16:33
@wence- wence- changed the base branch from branch-23.06 to branch-23.08 June 7, 2023 16:33
@wence- wence- removed request for a team and nvdbaranec June 7, 2023 16:34
@wence- wence- force-pushed the wence/fea/document-indexing-bugs branch from da5991e to 5a370f4 Compare June 7, 2023 16:54
bdice
bdice reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions, otherwise LGTM.

python/cudf/cudf/tests/test_indexing.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_indexing.py Show resolved Hide resolved
vyasr
vyasr approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small requests, but nothing blocking. Thank you for diligently constructing all the necessary test cases here, it's super valuable.

python/cudf/cudf/tests/test_indexing.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_indexing.py Show resolved Hide resolved
python/cudf/cudf/tests/test_indexing.py Outdated Show resolved Hide resolved
@wence-
Copy link
Contributor Author

wence- commented Jun 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9c349a2 into rapidsai:branch-23.08 Jun 8, 2023
@wence- wence- deleted the wence/fea/document-indexing-bugs branch June 8, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@vyasr vyasr vyasr approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@wence- wence-

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
Pandas API Alignment and Coverage
Development

Successfully merging this pull request may close these issues.
3 participants
@wence- @vyasr @bdice