-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Purge non-empty nulls when setting validity #13335
[Java] Purge non-empty nulls when setting validity #13335
Conversation
Tests pass locally when I run
|
java/src/test/java/ai/rapids/cudf/ColumnViewNonEmptyNullsTest.java
Outdated
Show resolved
Hide resolved
java/src/test/java/ai/rapids/cudf/ColumnViewNonEmptyNullsTest.java
Outdated
Show resolved
Hide resolved
I am running benchmarks on a different version of this implementation based on suggestions from here. Will post an update soon |
I have run some numbers on my local workstation using different implementations. The script just reads a parquet file with a list[int] column and casts it to a string. The casting in turn calls the
It looks like the modifications in this PR, listed as |
/merge |
Description
When setting the validity buffer in
mergeAndSetValidity
method, we check to see two thingsChecklist