Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some libcudf functions to set the null count on returning columns #13331

Merged
merged 2 commits into from
May 15, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Fixes a few more places where the null count was not being set in a libcudf function before returning a column. A couple of places were setting the null count value into the mutable-view object. So the value was calculated correctly but not set into the actual column object.

Reference: #11968

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 10, 2023
@davidwendt davidwendt self-assigned this May 10, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 11, 2023
@davidwendt davidwendt marked this pull request as ready for review May 11, 2023 17:39
@davidwendt davidwendt requested a review from a team as a code owner May 11, 2023 17:39
@davidwendt davidwendt requested review from vyasr and bdice May 11, 2023 17:39
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 4fe3e38 into rapidsai:branch-23.06 May 15, 2023
@davidwendt davidwendt deleted the set-null-counts branch May 15, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants