Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cudf::detail::concatenate_masks to return null-count #13330

Merged
merged 6 commits into from
May 15, 2023
Merged

Change cudf::detail::concatenate_masks to return null-count #13330

merged 6 commits into from
May 15, 2023

Conversation

davidwendt
Copy link
Contributor

Description

Changes cudf::detail::concatenate_masks to also return the null count. This saves computing the null count in a separate kernel launch where this function is used. Also changes the detail/concatenate.cuh header to detail/concatenate_masks.hpp since contains no device code and only includes the detail::concatenate_masks() functions. The detail::concatenate() functions are already declared in detail/concatenate.hpp.
This is marked as non-breaking since it only effects a detail function.
Reference: #11968

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 10, 2023
@davidwendt davidwendt self-assigned this May 10, 2023
@github-actions github-actions bot added the conda label May 10, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 11, 2023
@davidwendt davidwendt marked this pull request as ready for review May 11, 2023 17:43
@davidwendt davidwendt requested review from a team as code owners May 11, 2023 17:43
hyperbolic2346
hyperbolic2346 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small const nit

cpp/src/copying/concatenate.cu Outdated Show resolved Hide resolved
bdice
bdice approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite nice. Thanks @davidwendt.

ajschmidt8
ajschmidt8 approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 23a77a6 into rapidsai:branch-23.06 May 15, 2023
@davidwendt davidwendt deleted the concat-masks-count branch May 15, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice bdice approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@mythrocks mythrocks Awaiting requested review from mythrocks mythrocks is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @hyperbolic2346 @bdice @ajschmidt8