Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move meta calculation in dask_cudf.read_parquet #13327

Merged
merged 7 commits into from
May 15, 2023
Merged

Move meta calculation in dask_cudf.read_parquet #13327

merged 7 commits into from
May 15, 2023

Conversation

rjzamora
Copy link
Member

@rjzamora rjzamora commented May 10, 2023 •
edited
Loading

Description

Implements ArrowDatasetEngine._create_dd_meta so that a cudf-backed meta object is created before the full "partitioning plan" is generated. This is important in the new dask expression project (dask-expr), where we need accurate metadata before the full partitioning plan is generated.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@rjzamora rjzamora added 2 - In Progress Currently a work in progress dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change helps: Dask labels May 10, 2023
@rjzamora rjzamora self-assigned this May 10, 2023
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 10, 2023
@rjzamora rjzamora changed the title Move meta calculation to happen earlier in dask_cudf.read_parquet Move meta calculation in dask_cudf.read_parquet May 10, 2023
@rjzamora rjzamora marked this pull request as ready for review May 11, 2023 13:25
@rjzamora rjzamora requested a review from a team as a code owner May 11, 2023 13:25
@rjzamora rjzamora added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 11, 2023
wence-
wence- requested changes May 11, 2023
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick

python/dask_cudf/dask_cudf/io/parquet.py Show resolved Hide resolved
python/dask_cudf/dask_cudf/io/parquet.py Outdated Show resolved Hide resolved
@rjzamora
Copy link
Member Author

Any other thoughts on this one @wence- ? Thanks for the review!

@wence-
Copy link
Contributor

wence- commented May 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 79c0116 into rapidsai:branch-23.06 May 15, 2023
@rjzamora rjzamora deleted the move-parquet-meta branch May 15, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wence- wence- wence- approved these changes

Assignees

@rjzamora rjzamora

Labels
3 - Ready for Review Ready for review by team dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjzamora @wence-