Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up distinct_count benchmark #13321

Merged
merged 7 commits into from
May 11, 2023
Merged

Clean up distinct_count benchmark #13321

merged 7 commits into from
May 11, 2023

Conversation

PointKernel
Copy link
Member

Description

This PR moves the distinct_count benchmark to the stream_compaction folder. It also adds peak memory usage information and targets the public API for performance evaluation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue tech debt improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 9, 2023
@PointKernel PointKernel requested a review from a team as a code owner May 9, 2023 19:26
@PointKernel PointKernel self-assigned this May 9, 2023
@PointKernel PointKernel requested review from bdice and davidwendt May 9, 2023 19:26
karthikeyann
karthikeyann reviewed May 11, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PointKernel
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 8a5a1f4 into rapidsai:branch-23.06 May 11, 2023
@PointKernel PointKernel deleted the reposition-distinct-count-bench branch May 11, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@PointKernel PointKernel

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PointKernel @karthikeyann @ttnghia