First check for BaseDtype
when infering the data type of an arbitrary object
#13295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an internal utility called
dtype()
that attempts to infer the data type of an arbitrary object. One of the first thing thatdtype()
does is attempt to callnp.dtype(obj)
. That can be slow for extremely large cardinality categorical data types, as it copies data to host (in particular, it attempts to call the object's__repr__
):Before this PR:
This PR ensures we attempt to do far less expensive inference first, before calling
np.dtype(...)
.After this PR: