Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally return compression statistics from ORC and Parquet writers #13294
Optionally return compression statistics from ORC and Parquet writers #13294
Changes from all commits
ab01a46
e48e965
056a2ed
8f41bd4
245cae0
d62a8ec
6c62bb9
3ca7b70
447f961
021b340
f4b99d0
0baf3e2
6e335e5
f006b06
4794064
2050818
f34cb9f
c90fc68
59ed107
cb4bde2
e032a03
6c97eb5
805a68e
6d33d2c
8c86a6b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handling for div by zero?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We let C++ handle it and return a
nan
. I added a note about this behavior in the docs ofcompression_ratio
.The alternative would be an optional, but I think
nan
fits better here.