-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw error if UNINITIALIZED is passed to cudf::state_null_count #13292
Throw error if UNINITIALIZED is passed to cudf::state_null_count #13292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great, but I'm not sure if we're handling UNINITIALIZED
properly in some places now.
For my own education, what is the idea behind the |
Valid question. I neglected to reference the appropriate issue #11968 where we discuss removing this to help with moving to a stream based interface. |
@bdice @PointKernel do you have any changes you want to see here, or is it good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @davidwendt!
/merge |
Description
Changes
cudf::state_null_count
to throw astd::invalid_argument
error whichmask_state::UNINITIALIZED
is passed. This change is part of removingUNKNOWN_NULL_COUNT
from cudf/libcudf.Reference: #11968
Checklist