Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if UNINITIALIZED is passed to cudf::state_null_count #13292

Merged
merged 7 commits into from
May 15, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented May 4, 2023

Description

Changes cudf::state_null_count to throw a std::invalid_argument error which mask_state::UNINITIALIZED is passed. This change is part of removing UNKNOWN_NULL_COUNT from cudf/libcudf.

Reference: #11968

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 4, 2023
@davidwendt davidwendt self-assigned this May 4, 2023
@davidwendt davidwendt changed the title Throw error if UNITIALIZED is passed to cudf::state_null_count Throw error if UNINITIALIZED is passed to cudf::state_null_count May 4, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 8, 2023
@davidwendt davidwendt marked this pull request as ready for review May 8, 2023 14:55
@davidwendt davidwendt requested a review from a team as a code owner May 8, 2023 14:55
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great, but I'm not sure if we're handling UNINITIALIZED properly in some places now.

cpp/src/copying/copy.cpp Show resolved Hide resolved
@PointKernel
Copy link
Member

This change is part of removing UNKNOWN_NULL_COUNT from cudf/libcudf.

For my own education, what is the idea behind the UNKNOWN_NULL_COUNT removal?

@davidwendt
Copy link
Contributor Author

This change is part of removing UNKNOWN_NULL_COUNT from cudf/libcudf.

For my own education, what is the idea behind the UNKNOWN_NULL_COUNT removal?

Valid question. I neglected to reference the appropriate issue #11968 where we discuss removing this to help with moving to a stream based interface.

@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels May 9, 2023
@davidwendt davidwendt requested a review from bdice May 9, 2023 18:36
@vyasr
Copy link
Contributor

vyasr commented May 11, 2023

@bdice @PointKernel do you have any changes you want to see here, or is it good to go?

Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidwendt!

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit b16f9c4 into rapidsai:branch-23.06 May 15, 2023
@davidwendt davidwendt deleted the uninitialized-null-mask branch May 15, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants